linux-kernel - Re: [PATCH] tty: Fix tcdrain hang due to tty chars_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090717181852.54b1e41f@lxorguk.ukuu.org.uk>
Date:	Fri, 17 Jul 2009 18:18:52 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Harris, Jeff" <Jeff_Harris@...trox.com>
Cc:	<alan@...ux.intel.com>, <vapier@...too.org>, <adobriyan@...il.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty: Fix tcdrain hang due to tty chars_in_buffer errors

On Fri, 17 Jul 2009 12:36:22 -0400
"Harris, Jeff" <Jeff_Harris@...trox.com> wrote:

> That was my other thought, but there are other kernel drivers which do
> report errors from chars_in_buffer.  A grep of the code shows
> ipw_chars_in_buffer in drivers/char/pcmcia/ipwireless/tty.c,
> hvc_chars_in_buffer in hvc_console.c, ntty_chars_in_buffer in nozomi.c,
> if_chars_in_buffer in isdn/gigaset/interface.c, etc.  Do they all need
> to be updated?  

Yes I've squashed a pile and there may be more left.

> Should the return type be unsigned int to make the behavior more
> explicit?  The signed type may be interpreted along the lines of a read
> or write call which returns a count or a negative value to indicate a
> failure.

That would simply have people returning very large numbers. I don't think
the compiler can cure that. Putting a WARN_ON(x < 0); might liven it up
though.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/