[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1247790189.27937.74.camel@pasglop>
Date: Fri, 17 Jul 2009 10:23:09 +1000
From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
To: Dave Airlie <airlied@...il.com>
Cc: Greg KH <greg@...ah.com>,
Tiago Vignatti <tiago.vignatti@...ia.com>,
Jesse Barnes <jbarnes@...tuousgeek.org>,
Dave Airlie <airlied@...hat.com>, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] vga: implements VGA arbitration on Linux
On Thu, 2009-07-16 at 13:54 +1000, Dave Airlie wrote:
> On Wed, Jul 15, 2009 at 2:15 AM, Greg KH<greg@...ah.com> wrote:
> > Minor comment:
> >
> >> +#ifdef DEBUG
> >> + printk(KERN_DEBUG "%s\n", __func__);
> >> +#endif
> >
> > You should just use 'dev_dbg() for any debugging statments like this.
> > You can turn them on and off dynamically, and you get all of the proper
> > device information as to what is going on automatically.
> >
> > Plus, there's no need for a #ifdef in the code, which is generally
> > frowned apon in .c files.
> >
>
> We don't have a device in this case, vga arb is more of an abstraction than
> an actual device.
>
> I suppose if we were feeling crazy we could add a platform device for it.
Then use pr_debug :-)
Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists