linux-kernel - Re: [PATCH 2/2] tracing/function: simplify for __ftrace_replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 Jul 2009 00:39:23 -0400
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tracing/function: simplify for
	__ftrace_replace_code()

On Fri, Jul 17, 2009 at 12:30:07PM +0800, Li Zefan wrote:
> >> +	if (enable && !(rec->flags & FTRACE_FL_NOTRACE)) {
> >> +		if (ftrace_filtered) {
> >> +			if (rec->flags & FTRACE_FL_FILTER)
> >> +				flag = FTRACE_FL_ENABLED;
> >> +		} else
> >> +			flag = FTRACE_FL_ENABLED;
> > 
> > 
> > The above can be factorized in
> > 
> > if (!ftrace_filtered || rec->flags & FTRACE_FL_FILTER)
> > 	flag = FTRACE_FL_ENABLED
> > 
> 
> I think it's better to put the latter condition into parentheses:
> 
> if (!ftrace_filtered || (rec->flags & FTRACE_FL_FILTER))
> 	flag = FTRACE_FL_ENABLED
> 

Ok. Done.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/