linux-kernel - Re: potential null dereference in sysfs_override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0907191712050.11571@localhost.localdomain>
Date:	Sun, 19 Jul 2009 17:12:58 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Dan Carpenter <error27@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <johnstul@...ibm.com>
Subject: Re: potential null dereference in sysfs_override_clocksource()

Dan,

On Sun, 19 Jul 2009, Dan Carpenter wrote:

> Hello,
> 
> I am testing a source checker (http://repo.or.cz/w/smatch.git).
> 
> It found an issue in sysfs_override_clocksource() from 
> kernel/time/clocksource.c.  If "len" is zero then "ovr" is null and 
> checking ovr->flags will oops on line 517.
> 
> kernel/time/clocksource.c
>    516          if (tick_oneshot_mode_active() &&
>    517              !(ovr->flags & CLOCK_SOURCE_VALID_FOR_HRES)) {
>    518                  printk(KERN_WARNING "%s clocksource is not HRT compatible. "

Indeed. I queued a fix.

Thanks for pointing it out,


       tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/