linux-kernel - Re: [PATCH] enable x2APIC without interrupt remapping under KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090719175914.GA27205@elte.hu>
Date:	Sun, 19 Jul 2009 19:59:14 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Gleb Natapov <gleb@...hat.com>
Cc:	Suresh Siddha <suresh.b.siddha@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sheng Yang <sheng@...ux.intel.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"avi@...hat.com" <avi@...hat.com>
Subject: Re: [PATCH] enable x2APIC without interrupt remapping under KVM


* Gleb Natapov <gleb@...hat.com> wrote:

> On Sun, Jul 19, 2009 at 06:27:35PM +0200, Ingo Molnar wrote:
> > 
> > * Gleb Natapov <gleb@...hat.com> wrote:
> > 
> > > +	if (!ret) {
> > > +		/* IR is required if there is APIC ID > 255 even when running
> > > +		 * under KVM
> > > +		*/
> > 
> > Eeek.
> > 
> > > +	if (x2apic_preenabled) {
> > > +		panic("x2apic enabled by bios. But IR enabling failed."
> > > +		      " Check that CONFIG_X86_X2APIC and CONFIG_INTR_REMAP are"
> > > +		      " enabled.");
> > 
> > We dont want to break such messages mid-line, it makes it hard to 
> > git-grep for them. Also, the '. But' looks weird.
> 
> So what should I do? Make really long line?

i'd suggest short ones generally, like:

	"x2apic: enabled by BIOS but kernel init failed."

also, referring to whether the config are enabled is a bit lame - we 
are in the kernel so we should know whether they are enabled.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/