linux-kernel - Re: [PATCH 2/2] vga: drops a documentation regarding the VGA arbiter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090719185038.GA22095@tubao.research.nokia.com>
Date:	Sun, 19 Jul 2009 21:50:38 +0300
From:	"Vignatti Tiago (Nokia-D/Helsinki)" <tiago.vignatti@...ia.com>
To:	ext Pavel Machek <pavel@....cz>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Dave Airlie <airlied@...hat.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] vga: drops a documentation regarding the VGA
	arbiter


On Sat, Jul 18, 2009 at 01:48:17PM +0200, ext Pavel Machek wrote:
> 
> > +I. Details and Theory of Operation
> > +==================================
> > +
> > +I.1 vgaarb
> > +----------
> > +
> > +The vgaarb is a module of the Linux Kernel. When it is initially loaded, it
> > +scans all PCI devices and add the VGA ones inside the arbitration. The arbiter
> 
> and adds?
> 
> 
> > +If the device is hot-{un,}plugged, there is a hook inside the module to notify
> > +them being added/removed in the system and automatically added/removed in
> > +the arbiter.
> 
> I don't see who's 'them' here.
> 
> > +I.2 libpciaccess
> > +----------------
> > +
> > +To use the vga arbiter char device it was implemented a serie of functions
> 
> series?
> 
> > +inside the pciaccess library. Two fields were added to struct pci_device for
> > +this be possible:
> > +
> > +    /* the type of resource decoded by the device */
> > +    int vgaarb_rsrc;
> > +    /* the file descriptor (/dev/vga_arbiter) */
> > +    int vgaarb_fd;
> > +
> > +
> > +and the functions:
> > +
> 
> What functions?

Thanks for the review. I already updated the documentation here with your
comments.


Cheers,
            Tiago
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/