linux-kernel - Re: [PATCH] drivers/net/mlx4: Adjust constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0907192108270.18234@ask.diku.dk>
Date:	Sun, 19 Jul 2009 21:08:40 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers/net/mlx4: Adjust constant

Thanks for pointing this out.  I will look into it.

julia


On Sun, 19 Jul 2009, Joe Perches wrote:

> On Sun, 2009-07-19 at 18:09 +0200, Julia Lawall wrote:
> > From: Julia Lawall <julia@...u.dk>
> > 
> > The values in the advertising field are typically ADVERTISED_xxx, not
> > SUPPORTED_xxx.  Both SUPPORTED_10000baseT_Full and
> > ADVERTISED_1000baseT_Full have the same value.
> 
> other possibles:
> 
> drivers/net/sungem.c:#define ADVERTISE_MASK	(SUPPORTED_10baseT_Half | SUPPORTED_10baseT_Full | \
> 			 SUPPORTED_100baseT_Half | SUPPORTED_100baseT_Full | \
> 			 SUPPORTED_1000baseT_Half | SUPPORTED_1000baseT_Full | \
> 			 SUPPORTED_Pause | SUPPORTED_Autoneg)
> drivers/net/s2io.c:	info->advertising = (SUPPORTED_10000baseT_Full | SUPPORTED_FIBRE);
> drivers/net/spider_net.c:		advertise |= SUPPORTED_1000baseT_Full;
> drivers/net/spider_net.c:		advertise |= SUPPORTED_1000baseT_Half;
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/