linux-kernel - Re: [PATCH 3/10] drivers/hid: Move dereferences below a NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.0907200004310.11648@wotan.suse.de>
Date:	Mon, 20 Jul 2009 00:04:57 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Julia Lawall <julia@...u.dk>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/10] drivers/hid: Move dereferences below a NULL test

On Sun, 19 Jul 2009, Julia Lawall wrote:

> From: Julia Lawall <julia@...u.dk>
> 
> If the NULL test is necessary, then the dereferences should be moved below
> the NULL test.
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> // <smpl>
> @@
> type T;
> expression E,E1;
> identifier i,fld;
> statement S;
> @@
> 
> - T i = E->fld;
> + T i;
>   ... when != E=E1
>       when != i
>   if (E == NULL||...) S
> + i = E->fld;
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Good catch, applied, thanks Julia.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/