linux-kernel - Re: [PATCH] x86: NX protection for kernel data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090720114746.GA29811@elte.hu>
Date:	Mon, 20 Jul 2009 13:47:46 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Siarhei Liakh <sliakh.lkml@...il.com>,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Arjan van de Ven <arjan@...radead.org>,
	James Morris <jmorris@...ei.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@....de>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, linux-cris-kernel@...s.com,
	Roland Dreier <rdreier@...co.com>
Subject: Re: [PATCH] x86: NX protection for kernel data


* Sam Ravnborg <sam@...nborg.org> wrote:

> > >
> > > But here _edata does not cover until page boundary.
> > > And alignmnet is located outside the output section
> > > definition.
> > > It would be better/more consistent to follow the style you use for .text here.
> > 
> > You are correct. _edata should be the last thing in .data, and
> > alignment should be done before it. However, this brings up a
> > question: was there any specific reason to leave .data.init_task
> > beyond the _edata? Should we move _edata into the the last of the
> > .data.* sections to have poper view of kernel layout?
> 
> .data.init_task is loaded into another segment so this is less trivial.
> Jan Beulich has posted a patch some time ago to address this,
> but it failed when forwardported to the unified layout.
> 
> Btw. -tip (the x86 tree) has a patch included that unify the definition
> of _edata for 32 and 64 bit.
> So the best thing you can do is to base your patch on top of
> the -tip tree.

which can be found at:

  http://people.redhat.com/mingo/tip.git/README

When (re-)submitting the patch please point out the dependency.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/