[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090720151940.30bd38ca@hyperion.delvare>
Date: Mon, 20 Jul 2009 15:19:40 +0200
From: Jean Delvare <khali@...ux-fr.org>
To: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@...ux.intel.com>, lm-sensors@...sensors.org,
linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@....ac.uk>
Subject: Re: [PATCH] hwmon: Add WM835x PMIC hardware monitoring driver
On Mon, 20 Jul 2009 12:43:45 +0100, Mark Brown wrote:
> This driver provides reporting of the status supply voltage rails
> of the WM835x series of PMICs via the hwmon API.
>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>
> This should address all the issues Jean raised:
> - Add a brief document to the hwmon directory.
> - Use full constant names as arguments for template macro.
> - Use DIV_ROUND_CLOSEST()
> - Set driver owner.
> - Fix typos.
>
> Thanks to Jonathan and Jean for their reviews.
>
> Documentation/hwmon/wm8350 | 26 +++++++
> drivers/hwmon/Kconfig | 10 +++
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/wm8350-hwmon.c | 151 +++++++++++++++++++++++++++++++++++++++
> drivers/mfd/wm8350-core.c | 3 +
> include/linux/mfd/wm8350/core.h | 6 ++
> 6 files changed, 197 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/hwmon/wm8350
> create mode 100644 drivers/hwmon/wm8350-hwmon.c
Good work.
Acked-by: Jean Delvare <khali@...ux-fr.org>
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists