linux-kernel - Re: [PATCH 1/2] Add function to convert between calendar time andbroken-down time for universal use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04e101ca08e5$be078fa0$808410ac@zhaoleiwin>
Date:	Mon, 20 Jul 2009 10:56:55 +0800
From:	"Zhaolei" <zhaolei@...fujitsu.com>
To:	"Pavel Machek" <pavel@....cz>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	<mingo@...e.hu>, <tglx@...utronix.de>,
	<hirofumi@...l.parknet.co.jp>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Add function to convert between calendar time andbroken-down time for universal use

* From: "Pavel Machek" <pavel@....cz>
>> > +extern void gmtime(__kernel_time_t totalsecs,
>> > +        unsigned int *year, unsigned int *mon, unsigned int *mday,
>> > +        unsigned int *hour, unsigned int *min, unsigned int *sec,
>> > +        unsigned int *wday, unsigned int *yday);
>> > +extern void localtime(__kernel_time_t totalsecs,
>> > +        unsigned int *year, unsigned int *mon, unsigned int *mday,
>> > +        unsigned int *hour, unsigned int *min, unsigned int *sec,
>> > +        unsigned int *wday, unsigned int *yday);
> 
> 
> Should year/mon/.../yday be passed up as a structure?

Hello, Pavel

Thanks for your attention.

Actually, I considered to introduce a struct as your think, but finally I
choose to use arguments list instead of a struct, because:
1: User can easy to call this function without define a struct
2: Get rid of adding a additional struct into kernel

In fact, I think both(use a struct or not) should be ok.

Thanks
Zhaolei