linux-kernel - Re: [PATCH] RTC: mark if rtc-cmos drivers were successfully registered.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090720205726.GD4295@vespa.holoscopio.com>
Date:	Mon, 20 Jul 2009 17:57:26 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	dbrownell@...rs.sourceforge.net, bjorn.helgaas@...com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH] RTC: mark if rtc-cmos drivers were successfully
	registered.

On Mon, Jul 20, 2009 at 10:32:06PM +0200, Kay Sievers wrote:
> On Mon, Jul 20, 2009 at 22:19, Andrew Morton<akpm@...ux-foundation.org> wrote:
> > On Sun,  5 Jul 2009 01:07:59 -0300
> > Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com> wrote:
> >
> >> rtc-cmos has two drivers, one PNP and one platform. When PNP has not
> >> succeeded probing, platform is registered. However, it tries to
> >> unregister both drivers unconditionally, instead of only unregistering
> >> those that were successfully registered. Fix that with a boolean
> >> variable for each driver indicating whether registering was successful.
> 
> > This came up a few weeks ago - the kernel was actually crashing deep
> > down in the driver core, when a not-registered device was unregistered.
> >
> > I believe Kay was planning on making the driver core more robust, so
> > that crash shouldn't be happening any more.  Kay, can you please confirm
> > that thsi got fixed?
> 
> This is supposed to fix it:
>   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5c8563d773c0e9f0ac2a552e84806decd98ce732
> 
> Thanks,
> Kay

Yes, but instead of an oops, we get a warning when the driver could just
behave properly. That's the intention of this patch: do not warn the
user when there's nothing to warn about, as long as the driver behaves
itself. Doing an rmmod on a unused module should not give the user what
looks like an oops. I should start being more verbose with my commit
messages.  :-D

My best and thanks for you work,
Thadeu Cascardo.

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)