linux-kernel - Re: [PATCH 10/10] ksm: change ksm nice level to be 5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090720045037.GA24157@balbir.in.ibm.com>
Date:	Mon, 20 Jul 2009 10:20:37 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Izik Eidus <ieidus@...hat.com>
Cc:	akpm@...ux-foundation.org, hugh.dickins@...cali.co.uk,
	aarcange@...hat.com, chrisw@...hat.com, avi@...hat.com,
	riel@...hat.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	nickpiggin@...oo.com.au
Subject: Re: [PATCH 10/10] ksm: change ksm nice level to be 5

* Izik Eidus <ieidus@...hat.com> [2009-07-17 20:30:50]:

> From: Izik Eidus <ieidus@...hat.com>
> 
> ksm should try not to disturb other tasks as much as possible.
> 
> Signed-off-by: Izik Eidus <ieidus@...hat.com>
> ---
>  mm/ksm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/ksm.c b/mm/ksm.c
> index 75d7802..4afe345 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -1270,7 +1270,7 @@ static void ksm_do_scan(unsigned int scan_npages)
> 
>  static int ksm_scan_thread(void *nothing)
>  {
> -	set_user_nice(current, 0);
> +	set_user_nice(current, 5);

Is the 5 arbitrary? Why not +19? What is the intention of this change
- to run when no other task is ready to run?

> 
>  	while (!kthread_should_stop()) {
>  		if (ksm_run & KSM_RUN_MERGE) {

-- 
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/