linux-kernel - Re: x86: IPC driver patch for Intel Moorestown platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eisa33bq.fsf@basil.nowhere.org>
Date:	Tue, 21 Jul 2009 09:25:29 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"Gurudatt, Sreenidhi B" <sreenidhi.b.gurudatt@...el.com>,
	pazke@...trinvest.ru
Cc:	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...ux.intel.com>
Subject: Re: x86: IPC driver patch for Intel Moorestown platform

"Andrey Panin" <pazke@...trinvest.ru> writes:

Andrey, Your review would be easier to read if you removed the code
you're not commenting on.

>
> This inline function defined after being used. It's hard to tell whether gcc
> will actually inline it.

Near all supported gccs use "unit at a time" mode now and it's enabled,
so the order of functions in the file doesn't matter for inlining.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/