linux-kernel - Re: [RESEND Patch] kcore: remove its pointless size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090721174659.2c860ee4.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Tue, 21 Jul 2009 17:46:59 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, ebiederm@...ssion.com,
	xiyou.wangcong@...il.com, tao.ma@...cle.com,
	linux-kernel@...r.kernel.org, adobriyan@...il.com,
	mtk.manpages@...il.com, y-goto@...fujitsu.com
Subject: Re: [RESEND Patch] kcore: remove its pointless size

On Tue, 21 Jul 2009 11:09:24 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:

> On Fri, 17 Jul 2009 15:29:55 -0700
> Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > On Thu, 2 Jul 2009 09:41:38 +0900
> > KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:
> > I think I'm about to forget about the above issues.  If everyone else
> > does the same, they won't get addressed.  Oh well.
> > 
> > And I still need to decide whether
> > kcore-fix-proc-kcores-statst_size.patch fixes things up sufficiently
> > well to justify merging it.
> >
> 
> Hmm, I read fs/proc/kcore.c and feel followng, now.
> 
> - kclist doesn't handle memory hole, then, it will never be "correct" size.
>   For example, arch/x86/mm/init.c calls kclist_add() as following
> 
>   715         kclist_add(&kcore_vmalloc, (void *)VMALLOC_START,
>   716                    VMALLOC_END-VMALLOC_START);
> 
>   Wow, extremely big anyway.
> 
> - Then, yes. Size of /proc/kcode is pointless. Anyway, what's important is
>   not "size", but ELF phder of kcore.
> 
> To this patch,
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> 
Ah...BTW, if set size to be 0,
 %objdump -x /proc/kcore
returns immediately because objdump finds size as 0. but readelf seems to
work well.

Thanks,
-Kame




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/