linux-kernel - checkpatch whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2009 12:01:14 +0200
From:	Pavel Machek <pavel@....cz>
To:	apw@...onical.com, kernel list <linux-kernel@...r.kernel.org>
Subject: checkpatch whitespace

Hi!

Checkpatch regulary complains about bad whitespace:

pavel@amd:/data/l/linux-msm/drivers/input/touchscreen$
../../../scripts/checkpatch.pl --file synaptics_i2c_rmi.c
ERROR: trailing whitespace
#245: FILE: synaptics_i2c_rmi.c:245:
+^Ipr_info("synaptics: version %x, product property %x\n", $

ERROR: trailing whitespace
#250: FILE: synaptics_i2c_rmi.c:250:
+static void compute_areas(struct synaptics_ts_data *ts,^I$

ERROR: trailing whitespace
#326: FILE: synaptics_i2c_rmi.c:326:
+^I^I^I     -inactive_area_left, max_x + inactive_area_right, $

ERROR: trailing whitespace
#468: FILE: synaptics_i2c_rmi.c:468:
+^I^Ipr_err("synaptics: Unable to register %s input device\n", $

ERROR: trailing whitespace
#497: FILE: synaptics_i2c_rmi.c:497:
+^Ipr_info("synaptics: Start touchscreen %s in %s mode\n", $

total: 5 errors, 0 warnings, 635 lines checked


I don't think that a bit of trailing whitespace hurts that much (it is
very easy to create when fixing overly long lines, another checkpatch
complain), and at least akpm autofixes the whitespace, anyway, but...

Would it be possible to add autofixing to checkpatch? Fixing
whitespace issues by hand is useless & boring task...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/