linux-kernel - Re: [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the dbgp device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0907211033390.2967-100000@iolanthe.rowland.org>
Date:	Tue, 21 Jul 2009 10:34:53 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Jason Wessel <jason.wessel@...driver.com>
cc:	gregkh@...e.de, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <dbrownell@...rs.sourceforge.net>,
	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Yinghai Lu <yinghai@...nel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the
 dbgp device

On Tue, 21 Jul 2009, Jason Wessel wrote:

> Alan Stern wrote:
> > On Mon, 20 Jul 2009, Jason Wessel wrote:
> >> +    /* optional debug port, normally in the first BAR */
> >> +    temp = pci_find_capability(pdev, 0x0a);
> > This isn't going to work very well on systems with non-PCI EHCI
> > controllers.  Maybe you should leave debug-port detection in
> > ehci-pci.c.  The controller doesn't get reset very much in any case.
> >
>  
> 
> The high level debug port detection still needed to move, but you are
> correct, it needs to move with in the ehci-pci.c.
> 
> The ehci_reset() definitely clears the debug controller in the pci
> probe call to ehci_pci_setup().  The debug port detect code just needs
> to get called before the ehci_reset() in this case.
> 
> The repaired patch is inline below.

This is much better.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/