linux-kernel - Re: [PATCH v2] tracing/filters: Improve subsystem filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A651DF2.3060403@cn.fujitsu.com>
Date:	Tue, 21 Jul 2009 09:46:26 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Tom Zanussi <tzanussi@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] tracing/filters: Improve subsystem filter

>> Proposal 2:
>>
>>   # cat filter
>>   irq_handler_entry: irq == 5
>>   irq_handler_exit: none
>>   softirq_entry: vec == 1
>>   softirq_exit: vec == 2
> 
> I like proposal 2, it is very intuitive.
> 

Me too.

>> Which do you think is better? Or do you have some better idea?
>>
>> And in the failure case:
>>
>>   # echo 'irq == not_num' > filter
>>   bash: echo: write error: Invalid argument
>>
>> 1:
>>   # cat filter
>>   (still shows filters in each event like above)
>>
>> or shows error message (the current behavior)
> 
> No need to show error messages of failed filter modifications in the 
> "filter" file.
> 
>> 2:
>>   # cat filter
>>   irq == not_num
>>   ^
>>   parse_error: Couldn't find or set field in one of a subsystem's events
> 
> This looks good, BUT, it is too much. If you want to implement an error 
> message like the above, it should probably be a "pr_info()" thing.
> 

Yeah, I think it's too much too, but that's exactly what we have.
And I posted a patch to remove those error messages, but Tom and
Frederic didn't seem to like it:

	http://lkml.org/lkml/2009/6/17/89
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/