linux-kernel - Re: [PATCH 01/10] ehci early_printk: split ehci debug driver from early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jul 2009 20:54:19 -0500
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	gregkh@...e.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH 01/10] ehci early_printk: split ehci debug driver from
 early_printk.c

Yinghai Lu wrote:
> Jason Wessel wrote:
>   
>> Move the dbgp early printk driver in advance of refactoring and adding
>> new code, so the changes to this code are tracked separately from the
>> move of the code.
>>
>> The drivers/usb/early directory will be the location of the current
>> and future early usb code for driving usb devices prior initializing
>> the standard interrupt driven USB drivers.
>>
>> Signed-off-by: Jason Wessel <jason.wessel@...driver.com>
>> Cc: Greg KH <gregkh@...e.de>
>> Cc: Ingo Molnar <mingo@...e.hu>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Yinghai Lu <yinghai@...nel.org>
>> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
>> ---
>>  arch/x86/kernel/early_printk.c |  715 ---------------------------------------
>>  drivers/usb/Makefile           |    1 +
>>  drivers/usb/early/Makefile     |    5 +
>>  drivers/usb/early/ehci-dbgp.c  |  723 ++++++++++++++++++++++++++++++++++++++++
>>  include/linux/usb/ehci_def.h   |    6 +
>>  5 files changed, 735 insertions(+), 715 deletions(-)
>>  create mode 100644 drivers/usb/early/Makefile
>>  create mode 100644 drivers/usb/early/ehci-dbgp.c
>>     
>
> before this patch, we could use dbgp without compiling USB susbsystem in...
>
>   

And you shouldn't need it today.  You pointed out an error in the patch
which I will correct.  The drivers/Makefile needs to be changed, instead
of the drivers/usb/Makefile.

The dbgp code was changed in the patch series such that it works with or
with out the usb subsystem and with or without the earlyconsole=keep,...

All the code in the drivers/usb/early would work this way as well.  As
an example, I have an experimental UHCI serial driver that can be used
via the earlyprintk.

Thanks for the feed back.  I'll fix this for the v2 of the patch series.
Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/