linux-kernel - RE: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EAF47CD23C76F840A9E7FCE10091EFAB02B59503D1@dbde02.ent.ti.com>
Date:	Tue, 21 Jul 2009 11:03:53 +0530
From:	"Shilimkar, Santosh" <santosh.shilimkar@...com>
To:	"me@...ipebalbi.com" <me@...ipebalbi.com>
CC:	"Krishnamoorthy, Balaji T" <balajitk@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tony@...mide.com" <tony@...mide.com>,
	"khilman@...prootsystems.com" <khilman@...prootsystems.com>,
	"david-b@...bell.net" <david-b@...bell.net>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"sameo@...nedhand.com" <sameo@...nedhand.com>,
	"wim@...ana.be" <wim@...ana.be>,
	"timo.t.kokkonen@...ia.com" <timo.t.kokkonen@...ia.com>,
	"ben-linux@...ff.org" <ben-linux@...ff.org>,
	"lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>,
	"broonie@...nsource.wolfsonmicro.com" 
	<broonie@...nsource.wolfsonmicro.com>,
	"Nayak, Rajendra" <rnayak@...com>
Subject: RE: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable
 re-use

> -----Original Message-----
> From: Felipe Balbi [mailto:me@...ipebalbi.com] 
> Sent: Tuesday, July 21, 2009 10:55 AM
> To: Shilimkar, Santosh
> Cc: me@...ipebalbi.com; Krishnamoorthy, Balaji T; 
> linux-kernel@...r.kernel.org; tony@...mide.com; 
> khilman@...prootsystems.com; david-b@...bell.net; 
> linux-omap@...r.kernel.org; linux-i2c@...r.kernel.org; 
> sameo@...nedhand.com; wim@...ana.be; 
> timo.t.kokkonen@...ia.com; ben-linux@...ff.org; 
> lrg@...mlogic.co.uk; broonie@...nsource.wolfsonmicro.com; 
> Nayak, Rajendra
> Subject: Re: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver 
> files to enable re-use
> 
> hi,
> 
> On Tue, Jul 21, 2009 at 10:01:06AM +0530, Shilimkar, Santosh wrote:
> > > So IMO, renaming the files is unnecessary.
> > Well tps* are just catalog names of the twl4* family. So 
> you can keep adding whatever names there as long it's a same IC.
> > 
> > Perhaps you look in hurry to comment about this. Please 
> look at the intention of these patches. TWL6030 has PM IC 
> similar to TWL4030 with bit different interrupt management. 
> Audio IC is a separate one as compared to combined in case of TWL4030.
> > 
> > If it allows code re-use by renaming files, it should be 
> good. Isn't it ? 
> 
> What I'm trying to say is you can re-use the code even 
> without renaming
> those files, just add twl6030-irq and use some sort of 
> runtime check to
> use one or other irq mechanism.

We initially tried this but code is becoming ugly and not at all
readable. In fact this was a short cut and would have saved 
us some time :)

By renaming, we thought it can become a generic for further versions
of TWL IC's and adding support to those would be cleaner.

Let's get feedback from more people on the list

Regards,
Santosh--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/