linux-kernel - Re: [tip:x86/apic] x86/ioapic.c: unify ioapic_retrigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A676E89.9010606@goop.org>
Date:	Wed, 22 Jul 2009 12:54:49 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	Jeremy Fitzhardinge <Jeremy.Fitzhardinge@...rix.com>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [tip:x86/apic] x86/ioapic.c: unify ioapic_retrigger_irq()

On 07/18/09 05:05, tip-bot for Jeremy Fitzhardinge wrote:
> Commit-ID:  e25371d60cb06a44d7a32d7966ab9bfbeacb9390
> Gitweb:     http://git.kernel.org/tip/e25371d60cb06a44d7a32d7966ab9bfbeacb9390
> Author:     Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> AuthorDate: Mon, 8 Jun 2009 03:49:01 -0700
> Committer:  Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> CommitDate: Tue, 14 Jul 2009 13:32:51 -0700
>
> x86/ioapic.c: unify ioapic_retrigger_irq()
>
> The 32 and 64-bit versions of ioapic_retrigger_irq() are identical
> except the 64-bit one takes vector_lock.  vector_lock is defined and
> used on 32-bit too, so just use a common ioapic_retrigger_irq().
>   

Having another look at this patch, the other difference is that the
32-bit version just does:

    apic->send_IPI_self(irq_cfg(irq)->vector);

whereas the 64-bit does:

    apic->send_IPI_mask(cpumask_of(cpumask_first(cfg->domain)),
    cfg->vector);


Does 32-bit do the whole vector domain thing now?  Are these actually
equivalent?  Sending to self seems like it should be more efficient.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/