linux-kernel - Re: [PATCH] SPI driver for LMS283GF05 LCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090722135243.ac1accfb.akpm@linux-foundation.org>
Date:	Wed, 22 Jul 2009 13:52:43 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Marek Vasut <marek.vasut@...il.com>
Cc:	linux-kernel@...r.kernel.org, rpurdie@...ys.net
Subject: Re: [PATCH] SPI driver for LMS283GF05 LCD

On Thu, 16 Jul 2009 10:04:02 +0200
Marek Vasut <marek.vasut@...il.com> wrote:

> >From b7077676a3016327ca1010d3bbc80a0b9f2742e5 Mon Sep 17 00:00:00 2001                     
> From: Marek Vasut <marek.vasut@...il.com>                                                  
> Date: Thu, 16 Jul 2009 04:49:47 +0200                                                      
> Subject: [PATCH] Samsung LMS283GF05 LCD SPI support                                        
> 
> This patch adds support for the SPI part of LMS283GF05 LCD. The LCD uses
> SPI for initialization and powerdown sequences. No further defails are  
> specified in the datasheet about the initialization/powerdown sequence, 
> just the magic numbers that have to be sent over SPI bus. This LCD can  
> be found in the Aeronix Zipit Z2 handheld.                              

The patch is wordwrapped and has all its tabs replaced with spaces.

> 
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index f9d19be..3f9cce3 100644                                                 
> --- a/drivers/video/backlight/Kconfig                                         
> +++ b/drivers/video/backlight/Kconfig                                         
> @@ -31,6 +31,13 @@ config LCD_CORGI                                           
>           Say y here to support the LCD panels usually found on SHARP         
>           corgi (C7x0) and spitz (Cxx00) models.                              
>                                                                               
> +config LCD_LMS283GF05                                                        
> +       tristate "Samsung LMS283GF05 LCD"                                     
> +       depends on LCD_CLASS_DEVICE && SPI_MASTER                             
> +       help                                                                  
> +         SPI driver for Samsung LMS283GF05. This provides basic support      
> +         for powering the LCD up/down through a sysfs interface.             
> +                                                                             

It generally looks OK to me.  Should it have a Kconfig dependency for
its use of the GPIO layer?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/