linux-kernel - Re: [PATCH] power: trivial comment fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200907222316.41026.rjw@sisk.pl>
Date:	Wed, 22 Jul 2009 23:16:40 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	Trivial Patch Monkey <trivial@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power: trivial comment fixes

On Wednesday 22 July 2009, Randy Dunlap wrote:
> On Fri, 17 Jul 2009 03:19:02 +0200 Rafael J. Wysocki wrote:
> 
> > On Thursday 16 July 2009, Wu Fengguang wrote:
> > > CC: Rafael J. Wysocki <rjw@...k.pl>
> > > Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> > 
> > Thanks for the patch, I'll add it to the suspend tree when I'm back home
> > (probably on Monday).
> > 
> > Best,
> > Rafael
> > 
> > 
> > > ---
> > >  kernel/power/snapshot.c |    4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > --- linux.orig/kernel/power/snapshot.c
> > > +++ linux/kernel/power/snapshot.c
> > > @@ -233,7 +233,7 @@ static void *chain_alloc(struct chain_al
> > >  
> > >  #define BM_END_OF_MAP	(~0UL)
> > >  
> > > -#define BM_BITS_PER_BLOCK	(PAGE_SIZE << 3)
> > > +#define BM_BITS_PER_BLOCK	(PAGE_SIZE * BITS_PER_BYTE)
> > >  
> > >  struct bm_block {
> > >  	struct list_head hook;	/* hook into a list of bitmap blocks */
> > > @@ -275,7 +275,7 @@ static void memory_bm_free(struct memory
> > >  
> > >  /**
> > >   *	create_bm_block_list - create a list of block bitmap objects
> > > - *	@nr_blocks - number of blocks to allocate
> > > + *	@pages - number of pages to track
> > >   *	@list - list to put the allocated blocks into
> > >   *	@ca - chain allocator to be used for allocating memory
> > >   */
> 
> BTW:
> kernel-doc uses @parameter:
> and not         @parameter -

Yes, kerneldocs in this file generally require fixes.  They're somewhere in my
todo list.

Best,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/