linux-kernel - Re: [PATCH 17/19] ceph: ioctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Jul 2009 00:39:25 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Sage Weil <sage@...dream.net>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/19] ceph: ioctls

Sage Weil <sage@...dream.net> writes:

> A few Ceph ioctls for getting and setting file layout (striping)
> parameters.

It would be good if you posted manpages for these ioctls
so that the interface can be reviewed. After all
that's intended to be used by applications, isn't it?

There don't seem to be compat ioctl handlers?

> diff --git a/fs/ceph/ioctl.h b/fs/ceph/ioctl.h
> new file mode 100644
> index 0000000..537c27b
> --- /dev/null
> +++ b/fs/ceph/ioctl.h
> @@ -0,0 +1,12 @@
> +#ifndef FS_CEPH_IOCTL_H
> +#define FS_CEPH_IOCTL_H
> +
> +#include <linux/ioctl.h>
> +#include "types.h"
> +
> +#define CEPH_IOCTL_MAGIC 0x97
> +
> +#define CEPH_IOC_GET_LAYOUT _IOR(CEPH_IOCTL_MAGIC, 1, struct ceph_file_layout)
> +#define CEPH_IOC_SET_LAYOUT _IOW(CEPH_IOCTL_MAGIC, 2, struct ceph_file_layout)

How should the application use that if the include file is in fs/ceph?
Should be in include/linux I guess

Also this file should define all the types needed for the interface,
especialy struct ceph_file_layout, but no kernel internal types.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/