linux-kernel - Re: [PATCH 3/3] ide-tape: fix handling of postponed rqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090721.204704.123531717.davem@davemloft.net>
Date:	Tue, 21 Jul 2009 20:47:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	petkovbb@...glemail.com
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ide-tape: fix handling of postponed rqs

From: Borislav Petkov <petkovbb@...glemail.com>
Date: Sat, 18 Jul 2009 11:55:17 +0200

> ide-tape used to hit
> 
> [   58.614854] ide-tape: ht0: BUG: Two DSC requests queued!
> 
> due to the fact that another rq was being issued while the driver was
> waiting for DSC to get set for the device executing ATAPI commands which
> set the DSC to 1 to indicate completion.
> 
> Here's a sample output of that case:

Do you even compile the code you send me and look to see if there are
any new warnings generated or anything like that?

drivers/ide/ide-tape.c: In function ‘ide_tape_stall_queue’:
drivers/ide/ide-tape.c:379: warning: unused variable ‘rq’

Fix this.