linux-kernel - Re: [PATCH 03/20] percpu: rename 4k first chunk allocator to page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A6697D9.1000704@kernel.org>
Date:	Wed, 22 Jul 2009 13:38:49 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Christoph Lameter <cl@...ux-foundation.org>
CC:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	mingo@...hat.com, benh@...nel.crashing.org, davem@...emloft.net,
	dhowells@...hat.com, npiggin@...e.de, JBeulich@...ell.com,
	rusty@...tcorp.com.au, hpa@...or.com, tglx@...utronix.de,
	akpm@...ux-foundation.org, x86@...nel.org, andi@...stfloor.org
Subject: Re: [PATCH 03/20] percpu: rename 4k first chunk allocator to page

Christoph Lameter wrote:
> On Tue, 21 Jul 2009, Tejun Heo wrote:
> 
>> - * Boring fallback 4k allocator.  This allocator puts more pressure on
>> - * PTE TLBs but other than that behaves nicely on both UMA and NUMA.
>> + * Boring fallback 4k page allocator.  This allocator puts more
> 
> Guess this should not mentione 4k anymroe? page size allocation?

That's x86 specific code and PAGE_SIZE is always 4k there, so....
Also, this comment gets completely deleted by later patches anyway.

>>  				pr_warning("PERCPU: %s allocator failed (%zd), "
>> -					   "falling back to 4k\n",
>> +					   "falling back to page\n",
> 
> "falling back to page size"?

So updated.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/