linux-kernel - Re: [PATCH] acerhdf: convert to dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090723082904.GE3997@dtor-d630.eng.vmware.com>
Date:	Thu, 23 Jul 2009 01:29:04 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Peter Feuerer <peter@...e.net>
Cc:	Borislav Petkov <petkovbb@...glemail.com>, lenb@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acerhdf: convert to dev_pm_ops

On Wed, Jul 15, 2009 at 08:36:43PM +0200, Peter Feuerer wrote:
> Works fine here, thanks!
>
> Acked-by: Peter Feuerer <peter@...e.net>

Umm, did you test suspend-to-disk? As far as I understand the new
suspend() and resume() methods are onluy used for S2R and for S2D you need
to use freeze() and thaw().

>
> Borislav Petkov writes:
>
>> Signed-off-by: Borislav Petkov <petkovbb@...il.com>
>> ---
>>  drivers/platform/x86/acerhdf.c |   14 +++++++++-----
>>  1 files changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
>> index aa298d6..561b471 100644
>> --- a/drivers/platform/x86/acerhdf.c
>> +++ b/drivers/platform/x86/acerhdf.c
>> @@ -435,7 +435,7 @@ struct thermal_cooling_device_ops acerhdf_cooling_ops = {
>>  };
>>   /* suspend / resume functionality */
>> -static int acerhdf_suspend(struct platform_device *dev, pm_message_t state)
>> +static int acerhdf_suspend(struct device *dev)
>>  {
>>  	if (kernelmode)
>>  		acerhdf_change_fanstate(ACERHDF_FAN_AUTO);
>> @@ -446,7 +446,7 @@ static int acerhdf_suspend(struct platform_device *dev, pm_message_t state)
>>  	return 0;
>>  }
>>  -static int acerhdf_resume(struct platform_device *device)
>> +static int acerhdf_resume(struct device *dev)
>>  {
>>  	if (verbose)
>>  		pr_notice("resuming\n");
>> @@ -464,15 +464,19 @@ static int acerhdf_remove(struct platform_device *device)
>>  	return 0;
>>  }
>>  +static struct dev_pm_ops acerhdf_pm_ops = {
>> +	.suspend = acerhdf_suspend,
>> +	.resume	 = acerhdf_resume,
>> +};
>> +
>>  static struct platform_driver acerhdf_driver = {
>>  	.driver = {
>> -		.name = "acerhdf",
>> +		.name  = "acerhdf",
>>  		.owner = THIS_MODULE,
>> +		.pm    = &acerhdf_pm_ops,
>>  	},
>>  	.probe = acerhdf_probe,
>>  	.remove = acerhdf_remove,
>> -	.suspend = acerhdf_suspend,
>> -	.resume = acerhdf_resume,
>>  };
>>   

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/