linux-kernel - Re: New MMC maintainer needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090723135209.GD6570@console-pimps.org>
Date:	Thu, 23 Jul 2009 14:52:09 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Ohad Ben-Cohen <ohad@...cohen.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ian Molton <ian@...menth.co.uk>,
	Pierre Ossman <pierre@...man.eu>, linux-kernel@...r.kernel.org,
	linux-embedded@...r.kernel.org, nico@....org,
	nicolas.ferre@....atmel.com, hskinnemoen@...el.com,
	tony@...mide.com, david-b@...bell.net, manuel.lauss@...il.com,
	mirq-linux@...e.qmqm.pl, ppisa@...ron.com,
	jarkko.lavinen@...ia.com, ben@...ff.org, saschasommer@...enet.de,
	avorontsov@...mvista.com, oakad@...oo.com, HaraldWelte@...tech.com,
	JosephChan@....com.tw, adrian.hunter@...ia.com
Subject: Re: New MMC maintainer needed

On Thu, Jul 23, 2009 at 09:50:03AM +0300, Ohad Ben-Cohen wrote:
> Hi Andrew,
> 
> On Thu, Jul 23, 2009 at 9:22 AM, Andrew Morton<akpm@...ux-foundation.org> wrote:
> > I actually already have a little pile of MMC things queued:
> 
> Please also consider queuing up the attached patch as well.
> 
> The patch is removing the current SDIO cards 1.8V limit, which is
> needed for embedded
> SDIO devices like TI 127x WLAN devices (with 1.8V MMC controllers like we
> have on the ZOOM2 boards for example).
> 
> Thank you,
> Ohad.

> From f9ba45b537dd12fc09443ee29c48860665f8ac82 Mon Sep 17 00:00:00 2001
> From: Ohad Ben-Cohen <ohad@...cohen.org>
> Date: Wed, 15 Jul 2009 09:21:41 +0300
> Subject: [PATCH] sdio: do not ignore MMC_VDD_165_195
> 
> This is needed for 1.8V embedded SDIO devices and supporting host controllers
> (e.g. TI 127x and ZOOM2 boards)
> 
> Signed-off-by: Ohad Ben-Cohen <ohad@...cohen.org>
> ---
>  drivers/mmc/core/sdio.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index fb99ccf..6f221dc 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -275,13 +275,6 @@ int mmc_attach_sdio(struct mmc_host *host, u32 ocr)
>  		ocr &= ~0x7F;
>  	}
>  
> -	if (ocr & MMC_VDD_165_195) {
> -		printk(KERN_WARNING "%s: SDIO card claims to support the "
> -		       "incompletely defined 'low voltage range'. This "
> -		       "will be ignored.\n", mmc_hostname(host));
> -		ocr &= ~MMC_VDD_165_195;
> -	}
> -
>  	host->ocr = mmc_select_voltage(host, ocr);
>  
>  	/*
> -- 
> 1.5.4.3
> 

Looks OK to me, I'm unaware of a reason to not allow a card to use
MMC_VDD_165_195 if that's what it wants.

Acked-by: Matt Fleming <matt@...sole-pimps.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/