linux-kernel - Re: HTC Dream camera support for staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090723172854.GG28158@elf.ucw.cz>
Date:	Thu, 23 Jul 2009 19:28:54 +0200
From:	Pavel Machek <pavel@....cz>
To:	Arve Hj?nnev?g <arve@...roid.com>
Cc:	Brian Swetland <swetland@...gle.com>,
	Arve Hj??nnev??g <arve@...gle.com>,
	Iliyan Malchev <malchev@...gle.com>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: HTC Dream camera support for staging

On Mon 2009-07-13 15:05:04, Arve Hj?nnev?g wrote:
> On Mon, Jul 13, 2009 at 1:27 PM, Pavel Machek<pavel@....cz> wrote:
> ...
> >> > gpio_matrix: I thought in-tree zaurus keypad driver has recently
> >> > became generic enough to almost replace this?
> >>
> 
> I would recommend using our driver since it allows multiple input
> types in the same device. The generic matrix driver may work, but you
> will not get the power and camera keys in the same device. The generic
> driver also does not yet handle phantom keys, so if you for instance
> press right-alt+right-shift+p you will also get 9. Our gpio input
> driver also handles the trackball.

Well, matrix_keypad.c will need to be improved, then... Merging
duplicate code is not really an option.

> I have also seen devices that put the trackball click in the keypad
> matrix which means we have to change our gpio input driver to create
> multiple input devices. That change would also allow the two keypads
> on the G1 to be separate input devices which would allow both menu
> keys to report KEY_MENU.

Ok, I guess we should discuss this on linux-input.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/