linux-kernel - Re: [PATCH] hp-wmi: improve rfkill support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A68AB8F.9020609@tuffmail.co.uk>
Date:	Thu, 23 Jul 2009 19:27:27 +0100
From:	Alan Jenkins <alan-jenkins@...fmail.co.uk>
To:	Maciej Rutecki <maciej.rutecki@...il.com>
CC:	Matthew Garrett <mjg@...hat.com>,
	linux acpi <linux-acpi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hp-wmi: improve rfkill support

Maciej Rutecki wrote:
> 2009/7/21 Alan Jenkins <alan-jenkins@...fmail.co.uk>:
>   
>> 1) Add support for reading the hardware blocked state.  Previously
>>   we read a combination of the hardware and software blocked states,
>>   reporting it as the software blocked state.  This caused some
>>   confusing behaviour.
>>
>> 2) The software state is persistent, mark it as such.
>>
>> 3) Check rfkill in the resume handler.  Both the hard and soft
>>   blocked states may change over hibernation.
>>
>> Signed-off-by: Alan Jenkins <alan-jenkins@...fmail.co.uk>
>> Tested-by: Maciej Rutecki <maciej.rutecki@...il.com>
>>     
>
> It's this patch is added to -rc4?

No. 
<http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git&a=search&h=HEAD&st=commit&s=hp-wmi>

I didn't submit it for 2.6.31 because I didn't think it fixed a regression.

>  I one case I have strange behaviour.
>
> Before disable by button:
> root@...is:/home/maciek/Desktop# rfkill list
> 2: hp-wifi: Wireless LAN
>         Soft blocked: no
>         Hard blocked: no
> 3: hp-bluetooth: Bluetooth
>         Soft blocked: no
>         Hard blocked: no
> 16: hci0: Bluetooth
>         Soft blocked: no
>         Hard blocked: no
> 17: phy7: Wireless LAN
>         Soft blocked: no
>         Hard blocked: no
> 	
> Disable by button:
> root@...is:/home/maciek/Desktop# rfkill list
> 2: hp-wifi: Wireless LAN
>         Soft blocked: yes
>         Hard blocked: no
> 3: hp-bluetooth: Bluetooth
>         Soft blocked: yes
>         Hard blocked: no
> 17: phy7: Wireless LAN
>         Soft blocked: no
>         Hard blocked: yes
> 	
> I do s2disk. After resume from suspend to disk (still disabled by button):
> root@...is:/home/maciek/Desktop# rfkill list
> 2: hp-wifi: Wireless LAN
>         Soft blocked: yes
>         Hard blocked: no
> 3: hp-bluetooth: Bluetooth
>         Soft blocked: yes
>         Hard blocked: no
> 18: phy8: Wireless LAN
>         Soft blocked: no
>         Hard blocked: yes
> 	
> Try enable by button:
> root@...is:/home/maciek/Desktop# rfkill list
> 2: hp-wifi: Wireless LAN
>         Soft blocked: yes
>         Hard blocked: no
> 3: hp-bluetooth: Bluetooth
>         Soft blocked: yes
>         Hard blocked: no
> 18: phy8: Wireless LAN
>         Soft blocked: no
>         Hard blocked: yes
> 	
> Nothing change (LED, wireless and bluetooth don't work). To enable it
> I use this script rfkill.sh (I must use rfkill program):
>
> #!/bin/sh
> PROGRAM=/usr/local/sbin/rfkill
> WIFI=`$PROGRAM list | grep -E 'Wireless|Bluetooth' | cut -d  ':' -f 1`
>
> for DEVICE in $WIFI; do
>   echo $DEVICE
>   $PROGRAM unblock $DEVICE
> done
>
> Then works OK:
> root@...is:/home/maciek/Desktop# ./rfkill.sh
> 2
> 3
> 18
> root@...is:/home/maciek/Desktop# rfkill list
> 2: hp-wifi: Wireless LAN
>         Soft blocked: no
>         Hard blocked: no
> 3: hp-bluetooth: Bluetooth
>         Soft blocked: no
>         Hard blocked: no
> 18: phy8: Wireless LAN
>         Soft blocked: no
>         Hard blocked: no
> 19: hci0: Bluetooth
>         Soft blocked: no
>         Hard blocked: no
> 	
> It's normal behaviour?
>   

That's a bug.  You're saying this is in -rc4, without applying my patch?

I think I know exactly what is happening.  Apply my patch, and it will 
go away :-).

I'm not sure this is a new bug though.  It might be triggered by the big 
rfkill rewrite, but I don't see how that could happen.  Can you confirm 
if this happens in 2.6.30?

Thanks
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/