linux-kernel - Re: [PATCH 1/2] MMC Agressive clocking framework v5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63386a3d0907231325v42b05454u236c0103ae99a97f@mail.gmail.com>
Date:	Thu, 23 Jul 2009 22:25:21 +0200
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Adrian Hunter <adrian.hunter@...ia.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Pierre Ossman <pierre@...man.eu>,
	"linux-arm-kernel@...ts.arm.linux.org.uk" 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	David Vrabel <david.vrabel@....com>, marek.vasut@...il.com,
	Madhusudhan Chikkature <madhu.cr@...com>
Subject: Re: [PATCH 1/2] MMC Agressive clocking framework v5

2009/7/23 Adrian Hunter <adrian.hunter@...ia.com>:

> Have you considered using our enable/disable approach instead?

Didn't see that before, still an ran these patches by Tony... But
yes, I have *indeed* considered that approach and my first patch
was a lot like your, but at the time Pierre said:

> I'm not sure I agree with the design here. What's wrong with using the
> set_ios() callback and the normal clock field?

So I switched to using ios.clock instead, and that's what's been iterated.

That said, *I* am perfectly happy with your patch, so if you send that to
Andrew I will happily drop my patch and adapt the MMCI driver for
your stuff instead if that goes in.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/