linux-kernel - Re: [PATCH 3/5] drivers/isdn: Drop unnecessary NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200907241255.33013.isdn@linux-pingi.de>
Date:	Fri, 24 Jul 2009 12:55:32 +0200
From:	Karsten Keil <isdn@...ux-pingi.de>
To:	Julia Lawall <julia@...u.dk>
Cc:	isdn4linux@...tserv.isdn4linux.de, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/5] drivers/isdn: Drop unnecessary NULL test


ACK, thanks for spotting this.

I will include this in my next patchset.

Karsten

On Sonntag, 12. Juli 2009 22:05:03 Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
>
> The result of container_of should not be NULL.  In particular, in this case
> the argument to the enclosing function has passed though INIT_WORK, which
> dereferences it, implying that its container cannot be NULL.
>
> A simplified version of the semantic patch that makes this change is as
> follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> identifier fn,work,x,fld;
> type T;
> expression E1,E2;
> statement S;
> @@
>
> static fn(struct work_struct *work) {
>   ... when != work = E1
>   x = container_of(work,T,fld)
>   ... when != x = E2
> - if (x == NULL) S
>   ...
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@...u.dk>
>
> ---
>  drivers/isdn/hisax/amd7930_fn.c |    2 --
>  drivers/isdn/hisax/hfc_pci.c    |    2 --
>  drivers/isdn/hisax/hfc_sx.c     |    2 --
>  drivers/isdn/hisax/icc.c        |    2 --
>  drivers/isdn/hisax/isac.c       |    2 --
>  drivers/isdn/hisax/w6692.c      |    2 --
>  6 files changed, 12 deletions(-)
...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/