linux-kernel - Re: [PATCH 2 2/4] cciss: use mutex instead of flag to indicate busy initializing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090723173252.a83eac26.akpm@linux-foundation.org>
Date:	Thu, 23 Jul 2009 17:32:52 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andrew Patterson <andrew.patterson@...com>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	mike.miller@...com, jens.axboe@...cle.com
Subject: Re: [PATCH 2 2/4] cciss: use mutex instead of flag to indicate busy
 initializing

On Tue, 21 Jul 2009 13:55:27 -0600
Andrew Patterson <andrew.patterson@...com> wrote:

> cciss: use mutex instead of flag to indicate busy initializing
> 
> Convert busy_initializing from simple integer flag to mutex, so we
> can use it to block and thus avoid some race conditions.
> 

But the code never blocks on busy_initializing.  The only place where
we do a mutex_lock() is in cciss_init_one().  Everywhere else we're
using the mutex as a boolean flag in weird ways.

I really don't have the time to work out what we're trying to do here. 
Does the code actually work?  If so I'm thinking we should merge it and
pretend that someone else did it :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/