linux-kernel - Re: [PATCH 08/19] ceph: address space operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090724065603.GA2045@basil.fritz.box>
Date:	Fri, 24 Jul 2009 08:56:03 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Sage Weil <sage@...dream.net>
Cc:	Trond Myklebust <trond.myklebust@....uio.no>,
	linux-fsdevel@...r.kernel.org, Andi Kleen <andi@...stfloor.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/19] ceph: address space operations

> The part I don't understand is what actually happens to pages after the 
> error flag set.  They're still uptodate, but no longer dirty?  And can be 
> overwritten/redirtied?  There's also an error flag on the address_space.  
> Are there any guidelines as far as which should be used?

Ideally both. The Page error flag prevents the data from being
consumed and the address space error flag makes sure errors are 
getting reported on fsync()/close() etc.  Also AS error is useful when
you don't have a clear page to assign the error to, e.g. if you
get an error indication that's not tied to a read operation.

BTW the upcoming hwpoison code can set such errors asynchronously
under you.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/