[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090724071411.GB10760@elf.ucw.cz>
Date: Fri, 24 Jul 2009 09:14:11 +0200
From: Pavel Machek <pavel@....cz>
To: Zhang Rui <rui.zhang@...el.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-pm <linux-pm@...ts.linux-foundation.org>,
linux-acpi <linux-acpi@...r.kernel.org>,
"Rafael J. Wysocki" <rjw@...k.pl>, Len Brown <lenb@...nel.org>,
Alan Stern <stern@...land.harvard.edu>,
Arjan van de Ven <arjan@...ux.intel.com>, dtor@...l.ru
Subject: Re: [PATCH V2 4/4] i8042: support async suspend and shutdown
On Fri 2009-07-24 11:02:12, Zhang Rui wrote:
>
> i8042 controller support device async actions.
>
> If boot option "dev_async_action" is added,
> i8042 controller and its child devices can be
> suspended/shutdown asynchronously.
>
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> ---
> drivers/input/serio/i8042.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/input/serio/i8042.c
> ===================================================================
> --- linux-2.6.orig/drivers/input/serio/i8042.c
> +++ linux-2.6/drivers/input/serio/i8042.c
> @@ -1285,14 +1285,21 @@ static int __init i8042_init(void)
> goto err_unregister_driver;
> }
>
> - err = platform_device_add(i8042_platform_device);
> + err = dev_async_register(&i8042_platform_device->dev,
> + DEV_ASYNC_SUSPEND | DEV_ASYNC_SHUTDOWN);
> if (err)
> goto err_free_device;
>
> + err = platform_device_add(i8042_platform_device);
> + if (err)
> + goto err_dev_async_unregister;
> +
> panic_blink = i8042_panic_blink;
>
> return 0;
>
> + err_dev_async_unregister:
> + dev_async_unregister(&i8042_platform_device->dev);
> err_free_device:
> platform_device_put(i8042_platform_device);
> err_unregister_driver:
I still do not like the interface: manually unregistering seems to be
ugly & error prone.
> @@ -1305,6 +1312,7 @@ static int __init i8042_init(void)
>
> static void __exit i8042_exit(void)
> {
> + dev_async_unregister(&i8042_platform_device->dev);
> platform_device_unregister(i8042_platform_device);
> platform_driver_unregister(&i8042_driver);
> i8042_platform_exit();
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists