linux-kernel - slqb enables interrupts very early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090725180321.GA24814@Chamillionaire.breakpoint.cc>
Date:	Sat, 25 Jul 2009 20:03:21 +0200
From:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	linux-kernel@...r.kernel.org
Subject: slqb enables interrupts very early

I've checkout slab-2.6/linux-next and noticed that the interrupts are
enabled very early by accident. Please look at the following call stack:

    start_kernel()
    kmem_cache_init()
    kmem_cache_open()
    down_write(&slqb_lock);
    __down_write()
    __down_write_nested()

Now, __down_write_nested() protects its internal structure the follwing
way:
    spin_lock_irq(&sem->wait_lock);
    ...
    spin_unlock_irq(&sem->wait_lock);

so once we return, we return with interrupts on.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/