linux-kernel - Re: [PATCH V2] au1xmmc: dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090725191037.GE14062@dtor-d630.eng.vmware.com>
Date:	Sat, 25 Jul 2009 12:10:37 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Frans Pop <elendil@...net.nl>
Cc:	Manuel Lauss <manuel.lauss@...glemail.com>,
	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
	Manuel Lauss <manuel.lauss@...il.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH V2] au1xmmc: dev_pm_ops conversion

On Sat, Jul 25, 2009 at 08:18:58PM +0200, Frans Pop wrote:
> On Saturday 25 July 2009, Dmitry Torokhov wrote:
> > On Wed, Jul 22, 2009 at 05:18:39PM +0200, Manuel Lauss wrote:
> > > Cc: Frans Pop <elendil@...net.nl>
> > > Signed-off-by: Manuel Lauss <manuel.lauss@...il.com>
> > >
> > > +
> > > +static struct dev_pm_ops au1xmmc_pmops = {
> > > +	.resume		= au1xmmc_resume,
> > > +	.suspend	= au1xmmc_suspend,
> > > +};
> > > +
> >
> > Was suspend to disk tested? It requires freeze()/thaw().
> 
> Is that a regression introduced by this patch then? If so, many more of 
> the recent dev_pm_ops conversion patches would need to be revisited.

Yes, as far as I understand they would. Let's ask Rafael to confirm...

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/