linux-kernel - Re: [Patch RFC 23/37] usb: gadgetfs: Convert semaphore to mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Jul 2009 15:56:39 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [Patch RFC 23/37] usb: gadgetfs: Convert semaphore to mutex

On Sun, 2009-07-26 at 08:18 +0000, Thomas Gleixner wrote:
> -               if (down_trylock (&epdata->lock) != 0)
> +               if (mutex_trylock(&epdata->lock) != 0)


You forget the mutex_trylock has an inverted return value..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/