linux-kernel - Re: [PATCH] fs/notify/inotify: decrement user inotify count on close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81b0412b0907260846i1cce0e81m6c7bf99263fb4c1@mail.gmail.com>
Date:	Sun, 26 Jul 2009 17:46:49 +0200
From:	Alex Riesen <raa.lkml@...il.com>
To:	Eric Paris <eparis@...hat.com>
Cc:	Keith Packard <keithp@...thp.com>, linux-kernel@...r.kernel.org,
	john@...nmccutchan.com, rlove@...ve.org, eparis@...isplace.org
Subject: Re: [PATCH] fs/notify/inotify: decrement user inotify count on close

On Thu, Jul 2, 2009 at 14:14, Eric Paris<eparis@...hat.com> wrote:
> On Wed, 2009-07-01 at 21:56 -0700, Keith Packard wrote:
>> The per-user inotify_devs value is incremented each time a new file is
>> allocated, but never decremented. This led to inotify_init failing after a
>> limited number of calls.
>>
>> Signed-off-by: Keith Packard <keithp@...thp.com>
>
> Thanks, I will push to Linus later today, sorry about the regression!
>

Hmm... Either the patch wasn't enough, or it was broken again.
On v2.6.31-rc4, I get this:

  # echo 10 >/proc/sys/fs/inotify/max_user_watches
  # inotifywatch -r /usr/lib # generate watches up to the limit
  Establishing watches...
  Failed to watch /bin; upper limit on inotify watches reached!
  Please increase the amount of inotify watches allowed per user via
`/proc/sys/fs/inotify/max_user_watches'.
  # inotifywatch /bin/true # just one watch for just one file

AFAIU, the second inotifywatch should work, and the watches of the first,
failed, run must be cleared.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/