linux-kernel - Re: [PATCH] IPVS: logging sizeof(struct ip_vs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5ddba180907270334m4bc4e968m85c16ea4756c3f5d@mail.gmail.com>
Date:	Mon, 27 Jul 2009 12:34:42 +0200
From:	Hannes Eder <heder@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, lvs-users@...uxvirtualserver.org,
	malcolm@...dbalancer.org, linux-kernel@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Simon Horman <horms@...ge.net.au>
Subject: Re: [PATCH] IPVS: logging sizeof(struct ip_vs_conn) on startup

On Mon, Jul 27, 2009 at 11:25, Eric Dumazet<eric.dumazet@...il.com> wrote:
> Well, ip_vs_conn_cache uses SLAB_HWCACHE_ALIGN, so this should be rounded up
> to L1 cache size. Or add "at least" like in line 1080
> of net/netfilter/ipvs/ip_vs_conn.c :
>
> IP_VS_DBG(0, "Each connection entry needs %Zd bytes at least\n",
>           sizeof(struct ip_vs_conn));

Good point.  Is there an easy way to figure out how much memory is
wasted for alignment by the slab allocator?  Otherwise I vote for the
"at least" approach.

-Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/