linux-kernel - Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878wia6u13.fsf@devron.myhome.or.jp>
Date:	Tue, 28 Jul 2009 00:10:48 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Jörg Schummer <ext-jorg.2.schummer@...ia.com>
Cc:	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-fsdevel\@vger.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label

Jörg Schummer <ext-jorg.2.schummer@...ia.com> writes:

> Hello again,
>
> just in case you (or perhaps somebody else) have a minute to assist me..
>
> On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote:
>
>> BTW, the patch has several bugs. fat_get_label_entry() doesn't check
>> IS_FREE(), is it right?
>
> Not 100% sure if it's needed in a consistent fs, but I guess it
> shouldn't do any harm, so I added it.

If label was removed, what happen? I was assumed utility does

    label_de->name[0] = DELETED_FLAG;


>> spin_lock() usage is wrong.
>
>>>From the code, I'm not totally sure then what inode_hash_lock is
> supposed to protect in fat_write_inode. Probably it should prevent that
> the dir entry of an inode is being moved around to another i_pos while
> it's being changed?
>
> But in the pre-patch version of fat_write_inode, shouldn't then
> mark_buffer_dirty(bh) be called when the lock is still held?

I meant, read/write of storage might sleep, so it shouldn't hold
spin_lock when does it.

If you set debug CONFIG_* of locking, I guess it will warn.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/