linux-kernel - Re: [Bisected] [Bug #13821] Replugging USB serial converter uses new device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jul 2009 11:34:55 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Carlos R. Mafra" <crmafra2@...il.com>
cc:	Greg KH <greg@...ah.com>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	Ferenc Wagner <wferi@...f.hu>,
	Kay Sievers <kay.sievers@...y.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [Bisected] [Bug #13821] Replugging USB serial converter uses
 new device node

On Mon, 27 Jul 2009, Carlos R. Mafra wrote:

> On Sun 26.Jul'09 at 22:28:27 +0200, Rafael J. Wysocki wrote:
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=13821
> > Subject		: Replugging USB serial converter uses new device node
> > Submitter	: Ferenc Wagner <wferi@...f.hu>
> > Date		: 2009-07-18 20:04 (9 days old)
> > References	: http://marc.info/?l=linux-kernel&m=124794754015776&w=4
> 
> I was scanning the regressions list and noticed that I could reproduce
> this bug.
> 
> So I bisected it to commit 335f8514f200e63d689113d29cb7253a5c282967
> ("tty: Bring the usb tty port structure into more use"), from Alan
> Cox.
> 
> I did not double check if reverting it from -rc4 fixes the issue,
> but I noticed that this patch touches drivers/usb/serial/option.c, which
> is the driver I used to test this problem.
> 
> If there is anything else I can do (give more info, test patches etc),
> please let me know.

Are you certain this really is a regression?  Under 2.6.30 and 2.6.27
the same thing happened if I unplugged a USB serial device while it was
in use.

Can you check whether the device is still being used when you unplug 
it?  For instance, is there still a pppd process trying to communicate 
with the device?  If there is, what happens if you kill all the 
processes using the serial device before you unplug it?

In short, it seems likely that this is not new behavior but rather the 
way usb-serial has worked all along.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/