linux-kernel - Re: [PATCH v2 -tip][RFC] serial8250: update to dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aec7e5c30907261957x2793e8b9m8183bba0c3c2539f@mail.gmail.com>
Date:	Mon, 27 Jul 2009 11:57:10 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Frans Pop <elendil@...net.nl>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Erik Ekman <erik@...o.se>, Alan Cox <alan@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 -tip][RFC] serial8250: update to dev_pm_ops

On Mon, Jul 27, 2009 at 5:52 AM, Frans Pop<elendil@...net.nl> wrote:
> On Sunday 26 July 2009, Rafael J. Wysocki wrote:
>> In fact, I wouldn't advise anyone to do these conversions mechanically.
>
> With hindsight I'd say you are correct.
>
> In that case would it maybe have been better to have a build time warning
> about the need to convert drivers rather than a run time one? Run time
> warnings have a much higher annoyance factor and will thus "invite" more
> people into having a shot at getting rid of them.

I'm the one who added the runtime warning and I agree that a build
time warning would have been more suitable. Exacly how to implement
that in this specific case is another question. I'm open to
suggestions. =)

The purpose was simply to move over to the new interface sooner than later.

> But I guess partly it's also just the nature of this change: it looks
> trivial due to the corresponding terms.

It should be pretty trivial. The tricky part is what gets used when in
the cases of CONFIG_HIBERNATION and CONFIG_SUSPEND. The dev_pm_ops
comment in include/linux/pm.h should guide people in the right
direction.

Thanks for your help!

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/