linux-kernel - Re: [PATCH] acerhdf: convert to dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090727183733.GB3044@liondog.tnic>
Date:	Mon, 27 Jul 2009 20:37:33 +0200
From:	Borislav Petkov <petkovbb@...glemail.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Peter Feuerer <peter@...e.net>, lenb@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acerhdf: convert to dev_pm_ops

On Mon, Jul 27, 2009 at 08:55:51AM -0700, Dmitry Torokhov wrote:
> On Thu, Jul 23, 2009 at 02:53:17PM +0200, Borislav Petkov wrote:
> > > Dmitry's right, suspend() and resume() are used only for S2R. Since
> > > the only thing we do when suspending/hibernating is set fan speed to
> > > auto, we might just as well replicate those functions to .freeze() and
> > > .thaw().
> > 
> > here's a fix:
> > 
> > --
> > From: Borislav Petkov <petkovbb@...il.com>
> > Date: Wed, 15 Jul 2009 17:33:32 +0200
> > Subject: [PATCH] acerhdf: convert to dev_pm_ops
> > 
> > v 1.1:
> > Add .freeze/.thaw func ptrs to support
> > suspend-to-disk, as suggested by Dmitry Torokhov.
> > 
> > Signed-off-by: Borislav Petkov <petkovbb@...il.com>
> > ---
> >  drivers/platform/x86/acerhdf.c |   16 +++++++++++-----
> >  1 files changed, 11 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> > index aa298d6..8cd7a7b 100644
> > --- a/drivers/platform/x86/acerhdf.c
> > +++ b/drivers/platform/x86/acerhdf.c
> > @@ -435,7 +435,7 @@ struct thermal_cooling_device_ops acerhdf_cooling_ops = {
> >  };
> > 
> >  /* suspend / resume functionality */
> > -static int acerhdf_suspend(struct platform_device *dev, pm_message_t state)
> > +static int acerhdf_suspend(struct device *dev)
> >  {
> >  	if (kernelmode)
> >  		acerhdf_change_fanstate(ACERHDF_FAN_AUTO);
> > @@ -446,7 +446,7 @@ static int acerhdf_suspend(struct platform_device
> > *dev, pm_message_t state)
> >  	return 0;
> >  }
> > 
> > -static int acerhdf_resume(struct platform_device *device)
> > +static int acerhdf_resume(struct device *dev)
> >  {
> >  	if (verbose)
> >  		pr_notice("resuming\n");
> > @@ -464,15 +464,21 @@ static int acerhdf_remove(struct platform_device *device)
> >  	return 0;
> >  }
> > 
> > +static struct dev_pm_ops acerhdf_pm_ops = {
> > +	.suspend = acerhdf_suspend,
> > +	.resume  = acerhdf_resume,
> > +	.freeze  = acerhdf_suspend,
> > +	.thaw	 = acerhdf_resume,
> > +};
> > +
> 
> Hmm, looking at the driver I think the only function that actually is
> needed is poweroff() that would turn the fan in automatic mode before
> shutting down. The driver does not perform any actions when resuming so
> why bother?

Agreed.

Also, the fan comes out of warm and cold reboot in mode AUTO and
when the driver is enabled, the fan is turned off on the next run of
thermal_zone_device_update() when the read out temperature is within
limits.

Correct me if I'm wrong, but the only reason I see for setting the
fan to mode AUTO before suspending/hibernating/etc is if it is taking
a really long time to hibernate and write RAM image to disk and the
machine is getting hot during that process. Otherwise, we might just
as well do _nothing_ when suspending and remove all suspend/resume
functionality altogether, no?

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/