linux-kernel - Re: [PATCH] Staging: hv: Transform typedef HANDLE into void *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090727192030.GA4201@suse.de>
Date:	Mon, 27 Jul 2009 12:20:30 -0700
From:	Greg KH <gregkh@...e.de>
To:	Nicolas Palix <npalix@...u.dk>
Cc:	hjanssen@...rosoft.com, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Staging: hv: Transform typedef HANDLE into void *

On Mon, Jul 27, 2009 at 09:11:34PM +0200, Nicolas Palix wrote:
> 
> Remove typedef HANDLE which aliases a void pointer and use void *
> anywhere HANDLE was used.

No, I would like to change this to be the "real" pointer that the HANDLE
was used for, instead of just a void pointer.  These need to point to
real structures.  I did this already for the locks, and can be done for
pretty much everything else as well.

> -int WorkQueueQueueWorkItem(HANDLE hWorkQueue, PFN_WORKITEM_CALLBACK workItem, void* context)
> +int WorkQueueQueueWorkItem(void *hWorkQueue, PFN_WORKITEM_CALLBACK workItem, void *context)
>  {
>  	WORKQUEUE *wq = (WORKQUEUE *)hWorkQueue;

Here's an example.  This should really be a pointer to a "work queue"
and not a void pointer at all.  Changes like that would be gladly
accepted.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/