linux-kernel - Re: [PATCH] softlockup: fix problem with long kernel pauses from kgdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1248725893.6987.2055.camel@twins>
Date:	Mon, 27 Jul 2009 22:18:13 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	Ingo Molnar <mingo@...e.hu>, lkml <linux-kernel@...r.kernel.org>,
	"Deng, Dongdong" <Dongdong.Deng@...driver.com>
Subject: Re: [PATCH] softlockup: fix problem with long kernel pauses from
 kgdb

On Mon, 2009-07-27 at 15:03 -0500, Jason Wessel wrote:
> 
> The fix is to simply invoke sched_clock_tick() to update "cpu sched
> clock" on exit from kgdb_handle_exception.

Is that a regular IRQ context, or is that NMI context?

> Signed-off-by: Dongdong Deng <Dongdong.Deng@...driver.com>
> Signed-off-by: Jason Wessel <jason.wessel@...driver.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: peterz@...radead.org
> ---
>  kernel/softlockup.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- a/kernel/softlockup.c
> +++ b/kernel/softlockup.c
> @@ -118,6 +118,9 @@ void softlockup_tick(void)
>         }
>  
>         if (touch_timestamp == 0) {
> +               /* If the time stamp was touched externally make sure the
> +                * scheduler tick is up to date as well */
> +               sched_clock_tick();
>                 __touch_softlockup_watchdog();
>                 return;
>         }
> 

Aside from the funny comment style (please fix) the fix does look
sensible.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/