linux-kernel - early platform drivers vs resource lookup by name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0907262320y3c5c3505h5d47d5c51025a536@mail.gmail.com>
Date:	Mon, 27 Jul 2009 02:20:06 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Greg KH <gregkh@...e.de>, damm@...l.co.jp
Cc:	linux-kernel@...r.kernel.org
Subject: early platform drivers vs resource lookup by name

ive been toying with the new early platform driver framework and
noticed a not-so-friendly feature wrt resource handling.  the
platform_device_add() function will take care of making sure that
every resource's name field is not NULL:
int platform_device_add(struct platform_device *pdev)
{
...
        if (r->name == NULL)
            r->name = dev_name(&pdev->dev);
...

unfortunately, the early_platform_add_devices() function does not have
similar code.  this leads to NULL pointer crashes if you attempt to
use any of the "byname" resource functions (e.g.
platform_get_resource_byname) and the resources in question arent
fully named.

is the simple fix here to add a resource loop to
early_platform_add_devices() that makes sure all the name fields are
non-NULL ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/