[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87y6q8aiks.fsf@devron.myhome.or.jp>
Date: Wed, 29 Jul 2009 01:16:51 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Alan Cox <alan@...rguk.ukuu.org.uk>,
"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
"Rafael J. Wysocki" <rjw@...k.pl>, Ray Lee <ray-lk@...rabbit.org>,
LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kdesu broken
Linus Torvalds <torvalds@...ux-foundation.org> writes:
>> n_tty_read() checks the pending buffer and consume it before
>> input_available_p().
>
> Why not move this _inside_ "input_available_p()"? There are only two
> call-sites, and strictly speaking they both want it.
The only reason for me is this is just quick hack.
Yes, I guess the input_available_p() is preferable place than my patch.
I'm still not checking the related path etc. deeply though.
Thanks.
--
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists