linux-kernel - Re: [PATCH -next] netxen: fix build when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090728113254.f0d1afb7.randy.dunlap@oracle.com>
Date:	Tue, 28 Jul 2009 11:32:54 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Dhananjay Phadke <dhananjay.phadke@...gic.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] netxen: fix build when CONFIG_INET=n

On Tue, 28 Jul 2009 11:25:19 -0700 Dhananjay Phadke wrote:

> Thanks Randy for catching, I didn't run  CONFIG_INET=n build.
> 
> I think, better option is to wrap code in netxen_nic_main.c with CONFIG_INET check,
> since it's not a mandatory feature.

OK, I'll leave that to you then.


> -Dhananjay
> ________________________________________
> From: Randy Dunlap [randy.dunlap@...cle.com]
> Sent: Tuesday, July 28, 2009 11:21 AM
> To: Stephen Rothwell; davem@...emloft.net
> Cc: linux-next@...r.kernel.org; LKML; netdev; Dhananjay Phadke
> Subject: [PATCH -next] netxen: fix build when CONFIG_INET=n
> 
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix netxen build errors when CONFIG_INET=n:
> 
> netxen_nic_main.c:(.text+0x1abb8a): undefined reference to `in_dev_finish_destroy'
> netxen_nic_main.c:(.init.text+0xd86e): undefined reference to `register_inetaddr_notifier'
> netxen_nic_main.c:(.exit.text+0x1b70): undefined reference to `unregister_inetaddr_notifier'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Dhananjay Phadke <dhananjay@...xen.com>
> ---
>  drivers/net/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20090728.orig/drivers/net/Kconfig
> +++ linux-next-20090728/drivers/net/Kconfig
> @@ -2666,7 +2666,7 @@ config MYRI10GE_DCA
> 
>  config NETXEN_NIC
>         tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC"
> -       depends on PCI
> +       depends on PCI && INET
>         help
>           This enables the support for NetXen's Gigabit Ethernet card.
> 
> 
> 
> 
> ---
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/