linux-kernel - Re: [PATCH] mm: Make it easier to catch NULL cache names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1248749739.30993.39.camel@pasglop>
Date:	Tue, 28 Jul 2009 12:55:39 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH] mm: Make it easier to catch NULL cache names

On Mon, 2009-07-27 at 19:52 -0700, Linus Torvalds wrote:
> 
> On Tue, 28 Jul 2009, Benjamin Herrenschmidt wrote:
> >
> > Right now, if you inadvertently pass NULL to kmem_cache_create() at boot
> > time, it crashes much later after boot somewhere deep inside sysfs which
> > makes it very non obvious to figure out what's going on.
> 
> Please don't do BUG_ON() when there are alternatives.
> 
> In this case, something like
> 
> 	if (WARN_ON(!name))
> 		return NULL;
> 
> would probably have worked too.

Fair enough..  I'll send a new patch.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/